Skip to content

🎨 [e2e] Improve MMUX test #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 9, 2025
Merged

🎨 [e2e] Improve MMUX test #8494

merged 14 commits into from
Oct 9, 2025
+12 −3

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 9, 2025 •
edited
Loading

What do these changes do?

This PR improves the metamodeling e2e test by adding better test stability and synchronization mechanisms:

  • Added test ID to the saving icon UI element to enable reliable test targeting
  • Added synchronization logic to wait for project saving completion before proceeding

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (4b88d15) to head (e283733).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8494      +/-   ##
==========================================
- Coverage   87.62%   87.62%   -0.01%     
==========================================
  Files        2001     2001              
  Lines       77905    77905              
  Branches     1338     1338              
==========================================
- Hits        68262    68261       -1     
- Misses       9243     9244       +1     
  Partials      400      400
Flag Coverage Δ *Carryforward flag
integrationtests 64.12% <ø> (ø)
unittests 86.32% <ø> (ø) Carriedforward from 4b88d15

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 84.27% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.06% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.98% <ø> (ø)
pkg_settings_library 90.20% <ø> (ø)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.87% <ø> (ø)
autoscaling 95.72% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.91% <ø> (ø)
dynamic_scheduler 96.80% <ø> (ø)
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.11% <ø> (ø)
storage 86.41% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.29% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b88d15...e283733. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Oct 9, 2025
@odeimaiz odeimaiz requested a review from Copilot October 9, 2025 14:25
@odeimaiz odeimaiz added this to the Cheops milestone Oct 9, 2025
Copilot AI reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the MMUX (metamodeling) end-to-end test by adding better test stability and synchronization mechanisms. The changes focus on making the response surface modeling test more robust by properly waiting for UI state changes.

Key changes:

  • Added explicit Enter key press after filling study title to ensure proper form submission
  • Added synchronization logic to wait for project saving completion before proceeding
  • Added test ID to the saving icon UI element to enable reliable test targeting

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test_response_surface_modeling.py Enhanced test flow with explicit form submission and project save synchronization
NavigationBar.js Added test ID to saving icon for improved test element targeting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@odeimaiz odeimaiz enabled auto-merge (squash) October 9, 2025 14:30
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for e283733.

🟢 All jobs passed!

But CI Insights is watching 👀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit fd9641d into ITISFoundation:master Oct 9, 2025
94 of 95 checks passed
This was referenced Oct 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wvangeit wvangeit wvangeit approved these changes

@alexpargon alexpargon alexpargon approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@GitHK GitHK Awaiting requested review from GitHK

@pcrespov pcrespov Awaiting requested review from pcrespov

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @wvangeit @alexpargon @matusdrobuliak66